[STORY-3495] doc: add CRs examples#36
Merged
sc-david-voisin merged 3 commits intomainfrom Mar 27, 2026
Merged
Conversation
sc-david-voisin
changed the title
|
|
||
| Example: | ||
| `config/samples/databases_v1alpha1_postgresql.yaml` | ||
| Examples: |
Contributor
There was a problem hiding this comment.
In the PR you add three files, but only two in the list, did you miss one? (the custom resource is not in the list)
Contributor
Author
There was a problem hiding this comment.
I did on purpose, I expect these examples to grow in the future, and I've listed the most significant ones.
sc-david-voisin
force-pushed
the
doc/story-3495/provide-crs-examples
branch
from
d4e3182 to
59f242f
Compare
Comment on lines
+30
to
+31
| - type: "managed_range" | ||
| range_id: "man-osc-fr1-egress" |
There was a problem hiding this comment.
What's the point of this range if we already allow all ?
Contributor
Author
There was a problem hiding this comment.
There is no point. This is a remain from my very first sample tests.
Fixed in c053a43
Comment on lines
+30
to
+31
| - type: "managed_range" | ||
| range_id: "man-osc-fr1-egress" |
Contributor
Author
There was a problem hiding this comment.
Same response as above.
john-scalingo
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide custom resources that: