Google Cloud Run: Improve schema#4631
Merged
hyperupcall merged 17 commits intoSchemaStore:masterfrom Apr 14, 2025
Merged
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
ewjoachim
force-pushed
the
cloud_run_improve
branch
from
a2e06c2 to
f8fd7d6
Compare
ewjoachim
commented
Apr 2, 2025
ewjoachim
commented
Apr 2, 2025
Contributor
Author
|
Note: all the comments above are just suggestions. If we merge as-is (provided there are no review comments), I'll already be plenty satisfied. |
Contributor
|
Let me know when this is ready to merge |
ewjoachim
force-pushed
the
cloud_run_improve
branch
from
f8fd7d6 to
5cfd506
Compare
Contributor
Author
|
@madskristensen This is ready to merge |
Member
|
Thanks! |
Contributor
Author
|
Thanks to you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4625
Improves the Cloud Run schema by:
"additionalProperties": falseeverywhere since Google enforces that (apparently)