Skip to content

Add allowUnusedPatches and update ignorePatchFailures#4663

Merged
github-actions[bot] merged 1 commit intoSchemaStore:masterfrom
btea:fix/ignorePatchFailures-add-allowUnusedPatches
Apr 19, 2025
Merged

Add allowUnusedPatches and update ignorePatchFailures#4663
github-actions[bot] merged 1 commit intoSchemaStore:masterfrom
btea:fix/ignorePatchFailures-add-allowUnusedPatches

Conversation

@btea
Copy link
Contributor

@btea btea commented Apr 19, 2025

https://pnpm.io/settings#allowunusedpatches

ref #4659

@kirbysayshi It looks like the #4659 title description and content modification are inconsistent.

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @danielbayley and @btea - if they write a comment saying "LGTM" then it will be merged.

@kirbysayshi
Copy link
Contributor

@btea thanks for fixing and letting me know! Not sure what happened, other than bouncing between too many similarly named fields and getting myself confused. My apologies for getting it wrong, I’m surprised that other PR was merged!

@btea
Copy link
Contributor Author

btea commented Apr 19, 2025

Indeed, there seem to be too many similar configurations at the moment. There are too many configuration files, and it is difficult for reviewers to identify them one by one.

Let's fix it.

@btea
Copy link
Contributor Author

btea commented Apr 19, 2025

LGTM

@github-actions github-actions bot merged commit ac86660 into SchemaStore:master Apr 19, 2025
5 checks passed
@github-actions
Copy link
Contributor

Merging because @btea is a code-owner of all the changes - thanks!

@btea btea deleted the fix/ignorePatchFailures-add-allowUnusedPatches branch April 19, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants