Drop editorconfig EOL configuration #5316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `.gitattributes` configures `text=auto`. This means text files will use, unless already committed differently in the repo, auto-convert line endings. My VS created mixed line endings even when duplicating existing lines. For now, revert the EOL configuration to restore previous behavior consistent to the gitattributes configuration. IMO, it would be preferable to use intentional EOL configuration without depending on auto-conversion, which has complex conditions and is error-prone. But this change does not do that (yet).
github-actions
bot
added
the
config:editorconfig
Contributor
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
Contributor
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5311 introduced these settings.
The
.gitattributesconfigurestext=auto. This means text files will use, unless already committed differently in the repo, auto-convert line endings.My VS created mixed line endings even when duplicating existing lines.
For now, revert the EOL configuration to restore previous behavior consistent to the gitattributes configuration.
IMO, it would be preferable to use intentional EOL configuration without depending on auto-conversion, which has complex conditions and is error-prone. But this change does not do that (yet).