Replace API image with JSON Schema logo #5317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace stylized JSON image, which is not the official JSON logo, with the JSON Schema logo. Image source: Official JSON Schema website sources at https://github.com/json-schema-org/website/blob/fd76cd790cc68928a5eadaa14a76dca28f70bea5/public/logo-blue.svg The text block starts with “The JSON API contains a list of JSON Schema files for known JSON file formats.”. Our API provides JSON Schema, so using a JSON schema logo seems appropriate, certainly more so than using only the official JSON logo. Positive consequences: * Scalable and high-dpi-capable SVG instead of PNG * Fixes dark scheme visual transparency edge rendering artifacts (consequence of dark mode introduced in SchemaStore#5313)
github-actions
bot
added
the
WARNING_AspNetFiles
Contributor
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
Contributor
|
Amazing. Thank you so much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace stylized JSON image, which is not the official JSON logo, with the JSON Schema logo.
Image source: Official JSON Schema website sources at https://github.com/json-schema-org/website/blob/fd76cd790cc68928a5eadaa14a76dca28f70bea5/public/logo-blue.svg
The text block starts with “The JSON API contains a list of JSON Schema files for known JSON file formats.”. Our API provides JSON Schema, so using a JSON schema logo seems appropriate, certainly more so than using only the official JSON logo.
Positive consequences:
The code block is a bit unfortunate for a good visual image size. The new logo is square. I decided on 192, which seems like a good balance between too small and too large and reasonable layout-wise regarding the code block and float content layout.
Screenshots
Open Questions
api.pngfile remain so it remains web-accessible, potentially serving old references? (from third parties)