feat(OnyxDataGrid): Implemented basic inline editing feature#4995
Merged
feat(OnyxDataGrid): Implemented basic inline editing feature#4995
Conversation
🦋 Changeset detectedLatest commit: fe1980c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoCa96
force-pushed
the
joca96/2778-data-grid-renderer-keyboard-integration
branch
6 times, most recently
from
dcbf2ce to
6f05fb2
Compare
larsrickert
approved these changes
Mar 13, 2026
packages/sit-onyx/src/components/OnyxDataGrid/examples/EditingExample.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxDataGrid/examples/OnyxDataGridFeatureExamples.stories.ts
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxDataGrid/features/base/base.ts
Outdated
Show resolved
Hide resolved
...es/sit-onyx/src/components/OnyxDataGrid/OnyxDataGridRenderer/OnyxDataGridRenderer.stories.ts
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxDataGrid/OnyxDataGridRenderer/OnyxDataGridRenderer.vue
Outdated
Show resolved
Hide resolved
larsrickert
reviewed
Mar 13, 2026
Collaborator
larsrickert
left a comment
larsrickert
left a comment
There was a problem hiding this comment.
Is it intended that the row height jumps when toggling the edit state?
Bildschirmaufnahme.2026-03-13.um.15.37.14.mov
JoCa96
force-pushed
the
joca96/2778-data-grid-renderer-keyboard-integration
branch
from
69cb608 to
0609762
Compare
This is an auto-generated pull request. All missing translations have been updated. Co-authored-by: JoCa96 <18483883+JoCa96@users.noreply.github.com>
JoCa96
force-pushed
the
joca96/2778-data-grid-renderer-keyboard-integration
branch
from
ac935a9 to
e06b17e
Compare
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: JoCa96 <18483883+JoCa96@users.noreply.github.com>
JoCa96
changed the title
…mnType "boolean" caused by icon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #2789