Skip to content

fix(OnyxFormElementV2): use correct label gap and input padding#5066

Merged
larsrickert merged 4 commits intomainfrom
larsrickert/4918-form-element-v2-changes
Mar 17, 2026
Merged

fix(OnyxFormElementV2): use correct label gap and input padding#5066
larsrickert merged 4 commits intomainfrom
larsrickert/4918-form-element-v2-changes

Conversation

@larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented Mar 16, 2026

Relates to #4918

Update OnyxFormElementV2 to:

  • use correct gap between label + body in compact density
  • use correct inline padding for input when leading/trailing icons exist
  • add missing deprecation docs for unstable components

Checklist

  • The added / edited code has been documented with JSDoc
  • If a new component is added, at least one Playwright screenshot test or functional test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)
  • I have performed a self review of my code ("Files changed" tab in the pull request)

@larsrickert larsrickert requested a review from a team as a code owner March 16, 2026 13:56
@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2026

🦋 Changeset detected

Latest commit: 8975d94

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
sit-onyx Patch
@sit-onyx/chartjs-plugin Patch
@sit-onyx/nuxt-docs Patch
@sit-onyx/nuxt Patch
@sit-onyx/tiptap Patch
@sit-onyx/vitepress-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This is an auto-generated pull request. All Playwright screenshots have
been updated.

Co-authored-by: larsrickert <67898185+larsrickert@users.noreply.github.com>
@larsrickert larsrickert added this pull request to the merge queue Mar 16, 2026
@larsrickert larsrickert removed this pull request from the merge queue due to a manual request Mar 16, 2026
@larsrickert larsrickert added this pull request to the merge queue Mar 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 16, 2026
@larsrickert larsrickert added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit 4b55515 Mar 17, 2026
17 checks passed
@larsrickert larsrickert deleted the larsrickert/4918-form-element-v2-changes branch March 17, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants