Skip to content

Conversation

@mknaranja
Copy link
Member

@mknaranja mknaranja commented Apr 25, 2025

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

[ ] The following questions are addressed in the documentation (if need be):

  • Developers (what did you do?, how can it be maintained?)

  • For users (how to use your work?)

  • For admins (how to install and configure your work?)

  • For documentation: Please write or update the Readme in the current working directory!

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@mknaranja mknaranja linked an issue Apr 25, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.80%. Comparing base (bba9d5b) to head (403078d).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #82       +/-   ##
===========================================
+ Coverage   28.39%   76.80%   +48.41%     
===========================================
  Files          86       61       -25     
  Lines        7020     2302     -4718     
===========================================
- Hits         1993     1768      -225     
+ Misses       5027      534     -4493     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mknaranja mknaranja requested review from julianlitz and removed request for julianlitz April 25, 2025 15:48
@mknaranja mknaranja merged commit 27de808 into main Apr 25, 2025
5 checks passed
@mknaranja mknaranja deleted the 81-correct-broken-code-coverage branch April 25, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct broken code coverage

3 participants