-
Notifications
You must be signed in to change notification settings - Fork 20
1410 Accelerate add_edge for large graphs #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1411 +/- ##
==========================================
+ Coverage 97.29% 97.31% +0.01%
==========================================
Files 180 187 +7
Lines 15646 16007 +361
==========================================
+ Hits 15223 15577 +354
- Misses 423 430 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HenrZu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Im still not entirely sure about the overall usefulness of the feature.
Do you have some information about the overhead caused by the sorting and checking for dublicates?
if we want to add this feature, we should also extend the documentation of the current add edge function starting in line 169.
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
…om:SciCompMod/memilio into 1410-accelerate-add-edges-for-large-graphs
HenrZu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes :) Some last comments, then we can merge it.
Also, I would strongly suggest moving the GraphBuilder to its own file.
HenrZu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great addition :)
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
GraphBuilderclass that stores unorganized node and edge vectors and then builds a proper, organized graph.GraphBuilderadd_edgeandadd_nodefunctions into void.If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1410