Skip to content

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Nov 14, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Extended the SEIR model to a SEIRDB (with D: dead but not yet buried and B: buried) structure.
  • Additional parameters are:
    a probability to recover (instead of getting "Removed" from SEIR) with counterprobability to die
    a time between dying and getting buried
    a probability to infect from dead but not yet buried state D

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu linked an issue Nov 14, 2025 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.27%. Comparing base (47f4820) to head (fcb6cd4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1424      +/-   ##
==========================================
- Coverage   97.29%   97.27%   -0.03%     
==========================================
  Files         180      184       +4     
  Lines       15646    15807     +161     
==========================================
+ Hits        15223    15376     +153     
- Misses        423      431       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HenrZu HenrZu requested a review from kilianvolmer November 17, 2025 09:03
Copy link
Contributor

@kilianvolmer kilianvolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast implementation! It looks overall good to me, I just made some minor remarks, mostly about documentation.
I do, however, have one big question: Which model are you implementing here? I thought you want to implement the Legrande model, but that contains a Hospitalized compartment. Did I get that wrong?

@HenrZu
Copy link
Contributor Author

HenrZu commented Nov 18, 2025

Thank you for the fast review :)
Regarding the model structure. The idea to extend the model in this way was proposed by Martin. This is not directly connected to a specific paper.

Copy link
Contributor

@kilianvolmer kilianvolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes! One small typo and please remove the formatting in the warning/error messages. Then we are ready to merge :)

@HenrZu HenrZu requested a review from kilianvolmer November 19, 2025 10:31
@kilianvolmer kilianvolmer merged commit 610a823 into main Nov 19, 2025
57 checks passed
@kilianvolmer kilianvolmer deleted the 1420-implement-seirdb-model branch November 19, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create SEIRDB model for Ebola

3 participants