Remove DiffEqBase dependency from subpackages, use SciMLBase directly#433
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Feb 9, 2026
Merged
Conversation
DiffEqBase re-exports build_solution, interp_summary, and solve from SciMLBase. Replace all DiffEqBase.build_solution/interp_summary calls with SciMLBase equivalents and remove unused DiffEqBase imports from FIRK, MIRK, MIRKN, Ascher, and Shooting subpackages to reduce dependency surface and avoid future deprecation warnings. Also fix BVPM2 test item to use skip=true with uncommented test body instead of commented-out code that triggers empty test set warnings. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Benchmark ResultsClick to check benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiffEqBase.build_solutionandDiffEqBase.interp_summarycalls withSciMLBaseequivalents in FIRK and MIRK subpackages (these are identical functions re-exported by DiffEqBase)DiffEqBasedependency from FIRK, MIRK, MIRKN, Ascher, and Shooting subpackages (both[deps]and[compat]entries)solveimport from DiffEqBase to SciMLBaseskip = truewith uncommented test body instead of commented-out code that triggers empty test set warnings in CIMotivation
The subpackages were importing DiffEqBase but only using functions that are available directly from SciMLBase. Removing the unnecessary dependency reduces the dependency surface and avoids potential future deprecation warnings as DiffEqBase continues to consolidate into SciMLBase.
Note: BoundaryValueDiffEqCore still retains DiffEqBase as a dependency since it's the foundational package.
Test plan
Pkg.test("BoundaryValueDiffEqFIRK"))🤖 Generated with Claude Code