Conversation
isaacsas
left a comment
isaacsas
left a comment
There was a problem hiding this comment.
Please ensure any JumpProblem’s that are used in sampling tests take the stable rng as input.
|
ready |
isaacsas
left a comment
isaacsas
left a comment
There was a problem hiding this comment.
Can we re-enable the hybrid remake tests now? I think that is supposedly fixed in the latest MTK.
|
I will update it here, and see what happens. Happy to merge if the uncommented tests work? |
|
Sure, or can save for a follow up to get this merged. Your choice. |
|
Shoudl be up soon (just need to double check that test to ensure it is actually correct, if it is it will be quick) |
|
Still gets errors for the |
|
That is unfortunate since the issue was marked as fixed and SciML/ModelingToolkit.jl#3571 was closed. We should get a new MWE showing errors together then. |
|
Yeah, I will have a closer look at exactly what is going on, whenever MTK didn't fix anything, or I missed something in the test. I did run all the updates and things failed, and at that point it seemed like a decent amount of effort/time which I did not have today. |
|
No worries, and thanks for looking into it! |
2 participants
Increased the timespan of one test. Previously it could actually fail very occasionally. The test is still fast (<1 second). Have run it 10000 times, still no failure.