Add support for passing bounds through to NonlinearSolve#87
Merged
ChrisRackauckas merged 2 commits intomasterfrom Feb 27, 2026
Merged
Add support for passing bounds through to NonlinearSolve#87ChrisRackauckas merged 2 commits intomasterfrom
ChrisRackauckas merged 2 commits intomasterfrom
Conversation
ChrisRackauckas
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84. One oddity is the support for
ModifiedKingCurveAlgorithmthat can useKingCurveAlgorithminternally, which does not support bounds because it's a linear fit. I opted to strip the bounds before passing the problem toKingCurveAlgorithm, but one could argue that it's better to not support bounds at all if not all parts of the algorithm supports it.Also refactored the tests a bit to make it easier to filter them. To reviewers, I've tried to keep the commits atomic so I'd recommend reviewing them one-by-one.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.