Add Unitful tests for constant extrapolation#381
Merged
ChrisRackauckas merged 7 commits intoSciML:masterfrom Feb 6, 2025
Merged
Add Unitful tests for constant extrapolation#381ChrisRackauckas merged 7 commits intoSciML:masterfrom
ChrisRackauckas merged 7 commits intoSciML:masterfrom
Conversation
Member
|
Needs tests or this is guaranteed to regress. |
Contributor
Author
|
Some of what prompted this would also be fixed by #379 , I suspect. I'll give that attempt a little time to merge, so this can be rebased on that, but I will plan to at least use this PR to add some tests for a reasonable set of behavior (e.g. at least the extrapolated values, if not the derivatives). |
Contributor
… into unitful_nan
This reverts commit dea437f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
After 7.0 (which made good changes), the extrapolation procedures are not kind to Unitful numbers.
MWE:
Without this PR, this produces a DimensionError:
A related bug that prompted this involved
typed_nannot having a definition for Unitful quantities, which is why I expand it to<:Number, not just<:AbstractFloat(This PR was prepared in a hurry while I was distracted. Will take a second look later on and make sure this is consistent throughout.)