Skip to content

Bump OrdinaryDiffEqCore.jl compat to v2, remove older v1 compat#347

Merged
ChrisRackauckas merged 3 commits intoSciML:masterfrom
abhro:bump-ordinarydiffeqcore-compat
Dec 14, 2025
Merged

Bump OrdinaryDiffEqCore.jl compat to v2, remove older v1 compat#347
ChrisRackauckas merged 3 commits intoSciML:masterfrom
abhro:bump-ordinarydiffeqcore-compat

Conversation

@abhro
Copy link
Contributor

@abhro abhro commented Dec 12, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
  • Any new documentation only uses public API

Additional context

In keeping with SciML/OrdinaryDiffEq.jl#2927

@abhro
Copy link
Contributor Author

abhro commented Dec 12, 2025

This PR should also probably bump the version? Unsure if this is a breaking change, however.

@devmotion
Copy link
Member

Unsure if this is a breaking change, however.

It's not breaking for users or other packages in general. However, it is breaking for the OrdinaryDiffEq subpackages that used to load @unpack indirectly via OrdinaryDiffEqCore.

@abhro abhro marked this pull request as ready for review December 12, 2025 17:36
@abhro
Copy link
Contributor Author

abhro commented Dec 12, 2025

It's not breaking for users or other packages in general. However, it is breaking for the OrdinaryDiffEq subpackages that used to load @unpack indirectly via OrdinaryDiffEqCore.

Got it, thanks! So would this be a minor or a patch release?

@devmotion
Copy link
Member

Minor: https://docs.sciml.ai/ColPrac/stable/#Changing-dependency-compatibility

Signed-off-by: abhro <5664668+abhro@users.noreply.github.com>
@ChrisRackauckas ChrisRackauckas merged commit c394930 into SciML:master Dec 14, 2025
26 of 28 checks passed
@abhro abhro deleted the bump-ordinarydiffeqcore-compat branch December 14, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants