Fix AbstractDiffEqArray getindex deprecation warnings in tests#366
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Feb 8, 2026
Conversation
Use `.u` to access underlying arrays from DiffEqArray objects returned by solution interpolation before comparison with `≈`, instead of relying on the deprecated `Base.getindex(::AbstractDiffEqArray, ::Int)` method that gets triggered by broadcasting during `isapprox`. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base.getindex(VA::AbstractDiffEqArray{T, N, A}, i::Int)that appear in CI during Interface and Integrators test groupsisapprox(≈) when comparingDiffEqArrayobjects returned by solution interpolation (e.g.,sol(25:100, idxs = 2)).uto extract the underlying array fromDiffEqArrayobjects before comparison, avoiding the deprecatedgetindexpathChanges
test/interface/save_idxs.jl(5 lines): Access.uonDiffEqArrayresults fromsol(range, idxs=...)anddde_int.integrator.sol(ts, idxs=...)before≈comparisonstest/integrators/iterator.jl(1 line): Access.uonintegrator4.sol(ts)before≈comparison with plainVectorTest plan
save_idxs Tests: 52/52 pass, zero deprecation warningsIterator Tests: 12/12 pass, zero deprecation warnings🤖 Generated with Claude Code