Skip to content

Handle empty Kwargs case in forwarddiff detection #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 3 commits into from
Oct 28, 2024
Merged

Handle empty Kwargs case in forwarddiff detection #1100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4df324
Handle empty Kwargs case in forwarddiff detection
ChrisRackauckas Oct 28, 2024
d5c2d4c
fix test
ChrisRackauckas Oct 28, 2024
67d2c8f
fix test
ChrisRackauckas Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/forwarddiff.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,11 +363,14 @@ function anyeltypedual(x::NamedTuple, ::Type{Val{counter}} = Val{0}) where {coun
anyeltypedual(values(x))
end

function DiffEqBase.anyeltypedual(
function anyeltypedual(
f::SciMLBase.AbstractSciMLFunction, ::Type{Val{counter}}) where {counter}
Any
end

anyeltypedual(::@Kwargs{}, ::Type{Val{counter}} = Val{0}) where {counter} = Any
anyeltypedual(::Type{@Kwargs{}}, ::Type{Val{counter}} = Val{0}) where {counter} = Any

@inline promote_u0(::Nothing, p, t0) = nothing

@inline function promote_u0(u0, p, t0)
Expand Down
2 changes: 1 addition & 1 deletion test/forwarddiff_dual_detection.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ for p in p_possibilities_missed
end

p_possibilities_notdual = [
(), (;), [2.0], [2.0, 2], [2.0, (2.0)], [2.0, MyStruct(2.0, 2.0f0)]
(), (;), [2.0], [2.0, 2], [2.0, (2.0)], [2.0, MyStruct(2.0, 2.0f0)], pairs((;))
]

for p in p_possibilities_notdual
Expand Down
Loading