Skip to content

Remove operators interface #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025
Merged

Remove operators interface #1131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/DiffEqBase.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ import SciMLBase: solve, init, step!, solve!, __init, __solve, update_coefficien
update_coefficients, isadaptive, wrapfun_oop, wrapfun_iip,
unwrap_fw, promote_tspan, set_u!, set_t!, set_ut!

import SciMLBase: AbstractDiffEqLinearOperator # deprecation path

import SciMLStructures

using Reexport
Expand Down
6 changes: 4 additions & 2 deletions src/callbacks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,8 @@ function find_callback_time(integrator, callback::ContinuousCallback, counter)
end
Θ = bisection(zero_func, (bottom_t, top_t), isone(integrator.tdir),
callback.rootfind, callback.abstol, callback.reltol)
integrator.last_event_error = DiffEqBase.value(ODE_DEFAULT_NORM(zero_func(Θ), Θ))
integrator.last_event_error = DiffEqBase.value(ODE_DEFAULT_NORM(
zero_func(Θ), Θ))
end
#Θ = prevfloat(...)
# prevfloat guerentees that the new time is either 1 floating point
Expand Down Expand Up @@ -507,7 +508,8 @@ function find_callback_time(integrator, callback::VectorContinuousCallback, coun
isone(integrator.tdir), callback.rootfind,
callback.abstol, callback.reltol)
if integrator.tdir * Θ < integrator.tdir * min_t
integrator.last_event_error = DiffEqBase.value(ODE_DEFAULT_NORM(zero_func(Θ), Θ))
integrator.last_event_error = DiffEqBase.value(ODE_DEFAULT_NORM(
zero_func(Θ), Θ))
end
end
if integrator.tdir * Θ < integrator.tdir * min_t
Expand Down
38 changes: 0 additions & 38 deletions test/affine_operators_tests.jl
View file
Open in desktop

This file was deleted.

64 changes: 0 additions & 64 deletions test/basic_operators_interface.jl
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,11 @@ end
@time @safetestset "Internal Rootfinders" include("internal_rootfinder.jl")
@time @safetestset "Plot Vars" include("plot_vars.jl")
@time @safetestset "Problem Creation Tests" include("problem_creation_tests.jl")
@time @safetestset "Affine differential equation operators" include("affine_operators_tests.jl")
@time @safetestset "Export tests" include("export_tests.jl")
@time @safetestset "Remake tests" include("remake_tests.jl")
@time @safetestset "High Level solve Interface" include("high_level_solve.jl")
@time @safetestset "DiffEqFunction tests" include("diffeqfunction_tests.jl")
@time @safetestset "Internal Euler" include("internal_euler_test.jl")
@time @safetestset "Basic Operators Interface" include("basic_operators_interface.jl")
@time @safetestset "Norm" include("norm.jl")
@time @safetestset "Utils" include("utils.jl")
@time @safetestset "ForwardDiff Dual Detection" include("forwarddiff_dual_detection.jl")
Expand Down
Loading