Skip to content

feat: implement some of the integrator interface for NullODEIntegrator #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 2 commits into from
Jun 11, 2025
Merged

feat: implement some of the integrator interface for NullODEIntegrator #1163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b720c53
feat: implement `u_modified!` for null integrator
AayushSabharwal Jun 11, 2025
950b26d
feat: implement `SciMLBase.check_error` for null integrator
AayushSabharwal Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,8 @@ function step!(integ::NullODEIntegrator, dt = nothing, stop_at_tdt = false)
end
return nothing
end
function SciMLBase.u_modified!(integ::NullODEIntegrator, u) end
SciMLBase.check_error(integ::NullODEIntegrator) = integ.sol.retcode

function hack_null_solution_init(prob)
if SciMLBase.has_initialization_data(prob.f)
Expand Down
7 changes: 7 additions & 0 deletions test/downstream/null_de.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,10 @@ end
sol = solve(prob)
@test sol.resid isa SVector{1, Float64}
end

@testset "`u_modified!` works on null integrators" begin
prob = ODEProblem(Returns(nothing), nothing, (0.0, 1.0))
integ = init(prob, Tsit5())
@test_nowarn SciMLBase.u_modified!(integ, Float64[])
@test SciMLBase.successful_retcode(SciMLBase.check_error(integ))
end
Loading