Respect Julia's color settings in error messages #1173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes issue #194 by checking the IOContext's :color property before using printstyled with colors. When Julia is run with --color=no, error messages will now display without ANSI color codes. Changes: - Check `get(io, :color, false)` before using printstyled with colors - Fall back to plain print() when colors are disabled - Applied to both CommonKwargError and checkkwargs warning messages Fixes #194 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--color=no:colorproperty before usingprintstyledwith colorsprint()when colors are disabledTest plan
--color=noand verify error messages display without color codesThis change ensures that DiffEqBase respects Julia's color settings, making it compatible with environments that don't support ANSI colors (like Weave.jl).
Fixes #194
🤖 Generated with Claude Code