Replace internal ITP implementation with SimpleNonlinearSolve.jl's ITP #1210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the internal `InternalITP` implementation from DiffEqBase and replaces it with the more robust and feature-complete `ITP` algorithm from SimpleNonlinearSolve.jl. ## Changes: 1. **Removed internal ITP implementation:** - Deleted `src/internal_itp.jl` containing `InternalITP` struct and solver - Removed helper functions like `prevfloat_tdir`, `nextfloat_tdir`, `max_tdir` 2. **Added SimpleNonlinearSolve dependency:** - Added SimpleNonlinearSolve as a dependency in Project.toml - Set minimum version bound to 2.7 to ensure compatibility 3. **Updated usage throughout codebase:** - Modified `src/callbacks.jl` to use `ITP()` instead of `InternalITP()` - Updated `src/DiffEqBase.jl` to import `ITP` from SimpleNonlinearSolve - Updated `ext/DiffEqBaseForwardDiffExt.jl` to handle the new ITP algorithm - Updated `test/internal_rootfinder.jl` to test with the new ITP implementation ## Benefits: - **Better maintenance:** Eliminates duplicate code and reduces maintenance burden - **Improved reliability:** Uses the well-tested and optimized ITP implementation from SimpleNonlinearSolve - **Better performance:** SimpleNonlinearSolve's ITP has additional optimizations and tuning parameters - **Consistency:** Aligns with the broader SciML ecosystem's approach of using specialized packages ## Testing: All existing tests pass, including the specific internal rootfinder tests that verify the ITP algorithm works correctly for various edge cases. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the internal
InternalITPimplementation from DiffEqBase and replaces it with the more robust and feature-completeITPalgorithm from SimpleNonlinearSolve.jl.Motivation
Changes Made
1. Dependencies
SimpleNonlinearSolve = "2.7"to Project.toml dependencies and compat sections2. Code Changes
src/internal_itp.jl(98 lines removed)InternalITPstruct and associated solver implementationprevfloat_tdir,nextfloat_tdir,max_tdirsrc/DiffEqBase.jlusing SimpleNonlinearSolve: ITPinternal_itp.jlsrc/callbacks.jlInternalITP()withITP()in thebisectionfunctionext/DiffEqBaseForwardDiffExt.jlusing SimpleNonlinearSolve: ITPInternalITPtoITPtest/internal_rootfinder.jlDiffEqBase: InternalITPtoSimpleNonlinearSolve: ITPITPinstead ofInternalITPCompatibility Notes
InternalITPalgorithm from DiffEqBase's public APISimpleNonlinearSolve.ITP()instead ofDiffEqBase.InternalITP()bisectionfunction in callbacks continues to work as before, now using the more robust ITP implementationTesting
✅ All tests pass - The existing test suite validates that the replacement works correctly:
Test Summary: Internal Rootfinders | Pass: 20 Total: 20Performance Impact
The SimpleNonlinearSolve.jl ITP implementation offers:
🤖 Generated with Claude Code