Add downstream test for SubArray support #1220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds comprehensive test coverage for SubArray initial conditions in ODEProblems, addressing the regression test request from PR SciML#1219. Tests cover: - Basic ODEs with SubArray initial conditions - Simple pendulum example from issue #2900 - Various SubArray slicing patterns (range, colon, offset) This ensures that SubArrays work correctly with function wrapping after the fix in PR SciML#1219 that opts them out of AutoSpecialize. Fixes SciML#1219 (comment) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive test coverage for SubArray initial conditions in ODEProblems, addressing the regression test request from #1219 (comment).
Tests Added
This PR adds a new test file
test/downstream/subarray_support.jlthat covers:OrdinaryDiffEqTsit5with a subarray as initial conditions fails withLoadError: No matching function wrapper was found!OrdinaryDiffEq.jl#2900Background
PR #1219 fixed a
NoFunctionWrapperFoundErrorthat occurred when using SubArrays as initial conditions by opting them out of AutoSpecialize function wrapping. This PR adds the regression tests that were requested in the review to ensure this continues to work.Test Results
All 9 test cases pass:
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]