Wrap OverrideInitData functions in FWW for type erasure#1286
Closed
ChrisRackauckas-Claude wants to merge 1 commit intoSciML:masterfrom
Closed
Wrap OverrideInitData functions in FWW for type erasure#1286ChrisRackauckas-Claude wants to merge 1 commit intoSciML:masterfrom
ChrisRackauckas-Claude wants to merge 1 commit intoSciML:masterfrom
Conversation
…rasure Wraps three function-typed fields in OverrideInitData during promote_f: - NonlinearFunction.f in initializeprob (IIP, concrete arg types) - initializeprobmap (OOP, Any-typed args) - initializeprobpmap (OOP, Any-typed args) This erases the per-model RuntimeGeneratedFunction types so that models with the same state/parameter structure can reuse compiled solver code, reducing TTFX from ~4s to <1s per additional model. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Contributor
Author
|
Closing — the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OverrideInitDatawithFunctionWrappersWrapperduringpromote_f, erasing per-modelRuntimeGeneratedFunctiontypes:NonlinearFunction.fininitializeprob(IIP, concrete arg types)initializeprobmap(OOP,Any-typed args)initializeprobpmap(OOP,Any-typed args)Benchmark (MTK + Rodas5P, 4 models)
M2 benefits fully because it shares the same
MTKParameterstype as M1 (same number of states and params). M3/M4 still recompile because theirMTKParameterstypes differ.Test plan
🤖 Generated with Claude Code