Merged
Conversation
Replace deprecated `build_function(::Array{<:Equation}...)` call with the
non-deprecated form that passes RHS expressions directly. The new
`build_function` generates a vector parameter signature instead of
individual scalar parameters, so the Stan ODE solver integral strings
are updated accordingly to pass parameters as a vector.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_function(::Array{<:Equation}...) is deprecated. Use build_function(::AbstractArray...) instead.[eq.rhs for eq in equations(sys)]) instead ofEquationobjects tobuild_functioninstan_inference.jl[theta_1, theta_2, ...]') instead of individual scalars, matching the newbuild_functionoutput signatureDetails
The deprecated
build_functioncall withEquationobjects generated Stan functions with individualrealparameters:The new call with RHS expressions generates Stan functions with a
vectorparameter:The Stan ODE solver call (
ode_rk45_tol, etc.) is updated to pass a Stan vector[theta_1, theta_2, ...]'to match.Upstream deprecation notes
ParameterizedFunctions.@ode_deftriggers a@warnfrom ModelingToolkit about@independent_variables t— this is upstream in ParameterizedFunctions, not fixable hereCMDSTAN_HOMEwarning from StanBase is a test environment issue, not a code issuesample_u0=truetest (line 57) is stochastically flaky — it occasionally fails with value ~1e-6 vs expected 1.0, but this is a pre-existing MCMC convergence issue, not related to deprecationTest plan
JULIA_DEPWARN=error🤖 Generated with Claude Code