Fix setindex deprecation warnings in LU decomposition #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes deprecation warnings in the LU decomposition code that appear in Julia 1.11+ CI builds. The warnings are caused by deprecated
setindex(array, value, index)function calls on static vectors.Changes Made
setindex(ps, 1, kp - 1)calls with modern array reconstruction[ps...]to convert SVector to Array for modificationProblem Addressed
The code was using
setindex(ps, 1, kp - 1)which is deprecated in Julia 1.11+. This was causing "lots of little indexing" deprecation warnings in the Buildkite CI as mentioned in the issue.Solution
Replace the deprecated pattern:
With the modern approach:
Testing
These changes maintain identical functionality while using non-deprecated APIs. The existing test suite should continue to pass without deprecation warnings.
References
🤖 Generated with Claude Code