Skip to content

Fix remaining CI warnings and test failures #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Jul 30, 2025
Merged

Fix remaining CI warnings and test failures #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/gpu_kernel_de/conversions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,25 +23,25 @@ monteprob = EnsembleProblem(prob, prob_func = prob_func, safetycopy = false)
if ENV["GROUP"] ∉ ("Metal", "oneAPI")
@test solve(monteprob, GPUTsit5(), EnsembleGPUKernel(backend),
trajectories = 10_000,
saveat = 1:10)[1].t == Float32.(1:10)
saveat = 1:10).u[1].t == Float32.(1:10)

@test solve(monteprob, GPUTsit5(), EnsembleGPUKernel(backend),
trajectories = 10_000,
saveat = 1:0.1:10)[1].t == 1.0f0:0.1f0:10.0f0
saveat = 1:0.1:10).u[1].t == 1.0f0:0.1f0:10.0f0

@test solve(monteprob, GPUTsit5(), EnsembleGPUKernel(backend),
trajectories = 10_000,
saveat = 1:(1.0f0):10)[1].t == 1:1.0f0:10
saveat = 1:(1.0f0):10).u[1].t == 1:1.0f0:10

@test solve(monteprob, GPUTsit5(), EnsembleGPUKernel(backend),
trajectories = 10_000,
saveat = 1.0)[1].t == 0.0f0:1.0f0:10.0f0
saveat = 1.0).u[1].t == 0.0f0:1.0f0:10.0f0
end

@test solve(monteprob, GPUTsit5(), EnsembleGPUKernel(backend),
trajectories = 10_000,
saveat = [1.0f0, 5.0f0, 10.0f0])[1].t == [1.0f0, 5.0f0, 10.0f0]
saveat = [1.0f0, 5.0f0, 10.0f0]).u[1].t == [1.0f0, 5.0f0, 10.0f0]

@test solve(monteprob, GPUTsit5(), EnsembleGPUKernel(backend),
trajectories = 10_000,
saveat = [1.0, 5.0, 10.0])[1].t == [1.0f0, 5.0f0, 10.0f0]
saveat = [1.0, 5.0, 10.0]).u[1].t == [1.0f0, 5.0f0, 10.0f0]
14 changes: 7 additions & 7 deletions test/gpu_kernel_de/gpu_ode_continuous_callbacks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ for (alg, diffeq_alg) in zip(algs, diffeq_algs)
bench_sol = solve(prob, diffeq_alg,
adaptive = false, dt = 0.1f0, callback = cb, merge_callbacks = true)

@test norm(bench_sol.u - sol.u[1].u) < 2e-3
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 2e-3

@info "Callback: CallbackSets"

Expand All @@ -54,7 +54,7 @@ for (alg, diffeq_alg) in zip(algs, diffeq_algs)
bench_sol = solve(prob, diffeq_alg,
adaptive = false, dt = 0.1f0, callback = cb, merge_callbacks = true)

@test norm(bench_sol.u - sol.u[1].u) < 2e-3
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 2e-3

@info "saveat and callbacks"

Expand All @@ -67,7 +67,7 @@ for (alg, diffeq_alg) in zip(algs, diffeq_algs)
adaptive = false, dt = 1.0f0, callback = cb, merge_callbacks = true,
saveat = [0.0f0, 9.1f0])

@test norm(bench_sol.u - sol.u[1].u) < 2e-3
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 2e-3

@info "save_everystep and callbacks"

Expand All @@ -80,7 +80,7 @@ for (alg, diffeq_alg) in zip(algs, diffeq_algs)
adaptive = false, dt = 0.1f0, callback = cb, merge_callbacks = true,
save_everystep = false)

@test norm(bench_sol.u - sol.u[1].u) < 7e-4
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 7e-4

@info "Adaptive version"

Expand All @@ -94,7 +94,7 @@ for (alg, diffeq_alg) in zip(algs, diffeq_algs)
adaptive = true, save_everystep = false, dt = 0.1f0, callback = cb,
merge_callbacks = true)

@test norm(bench_sol.u - sol.u[1].u) < 2e-3
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 2e-3

@info "Callback: CallbackSets"

Expand All @@ -108,7 +108,7 @@ for (alg, diffeq_alg) in zip(algs, diffeq_algs)
adaptive = true, dt = 0.1f0, save_everystep = false, callback = cb,
merge_callbacks = true)

@test norm(bench_sol.u - sol.u[1].u) < 2e-3
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 2e-3

@info "saveat and callbacks"

Expand All @@ -123,7 +123,7 @@ for (alg, diffeq_alg) in zip(algs, diffeq_algs)
tstops = [24.0f0, 40.0f0], saveat = [0.0f0, 9.1f0], reltol = 1.0f-6,
abstol = 1.0f-6)

@test norm(bench_sol.u - sol.u[1].u) < 8e-4
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 8e-4

@info "Unadaptive and Adaptive comparison"

Expand Down
20 changes: 10 additions & 10 deletions test/gpu_kernel_de/gpu_sde_regression.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@ for alg in algs
# dX_t = u*dt + udW_t
f(u, p, t) = u
g(u, p, t) = u
u0 = @SVector [0.5f0]
local u0 = @SVector [0.5f0]

tspan = (0.0f0, 1.0f0)
prob = SDEProblem(f, g, u0, tspan; seed = 123)
local tspan = (0.0f0, 1.0f0)
local prob = SDEProblem(f, g, u0, tspan; seed = 123)

monteprob = EnsembleProblem(prob)
local monteprob = EnsembleProblem(prob)

dt = Float32(1 // 2^(8))

## solve using off-loading on CPU
sol = solve(monteprob, alg, EnsembleGPUKernel(backend), dt = dt, trajectories = 1000,
local sol = solve(monteprob, alg, EnsembleGPUKernel(backend), dt = dt, trajectories = 1000,
adaptive = false)

sol = solve(monteprob, alg, EnsembleGPUKernel(backend, 0.0), dt = dt,
Expand Down Expand Up @@ -50,13 +50,13 @@ for alg in algs
return SVector{3}(3.0f0, 3.0f0, 3.0f0)
end

u0 = @SVector [1.0f0, 0.0f0, 0.0f0]
tspan = (0.0f0, 10.0f0)
prob = SDEProblem(lorenz, σ_lorenz, u0, tspan)
monteprob = EnsembleProblem(prob)
local u0 = @SVector [1.0f0, 0.0f0, 0.0f0]
local tspan = (0.0f0, 10.0f0)
local prob = SDEProblem(lorenz, σ_lorenz, u0, tspan)
local monteprob = EnsembleProblem(prob)
dt = Float32(1 // 2^(8))

sol = solve(
local sol = solve(
monteprob, alg, EnsembleGPUKernel(backend, 0.0), dt = dt, trajectories = 10,
adaptive = false)

Expand Down
14 changes: 7 additions & 7 deletions test/gpu_kernel_de/stiff_ode/gpu_ode_continuous_callbacks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ for alg in algs
bench_sol = solve(prob, Rosenbrock23(),
adaptive = false, dt = 0.1f0, callback = cb, merge_callbacks = true)

@test norm(bench_sol.u - sol.u[1].u) < 8e-4
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 8e-4

@info "Callback: CallbackSets"

Expand All @@ -67,7 +67,7 @@ for alg in algs
bench_sol = solve(prob, Rosenbrock23(),
adaptive = false, dt = 0.1f0, callback = cb, merge_callbacks = true)

@test norm(bench_sol.u - sol.u[1].u) < 8e-4
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 8e-4

@info "saveat and callbacks"

Expand All @@ -80,7 +80,7 @@ for alg in algs
adaptive = false, dt = 1.0f0, callback = cb, merge_callbacks = true,
saveat = [0.0f0, 9.1f0])

@test norm(bench_sol.u - sol.u[1].u) < 5e-4
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 5e-4

@info "save_everystep and callbacks"

Expand All @@ -93,7 +93,7 @@ for alg in algs
adaptive = false, dt = 0.1f0, callback = cb, merge_callbacks = true,
save_everystep = false)

@test norm(bench_sol.u - sol.u[1].u) < 6e-4
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 6e-4

@info "Adaptive version"

Expand All @@ -107,7 +107,7 @@ for alg in algs
adaptive = true, save_everystep = false, dt = 0.1f0, callback = cb,
merge_callbacks = true)

@test norm(bench_sol.u - sol.u[1].u) < 2e-3
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 2e-3

@info "Callback: CallbackSets"

Expand All @@ -121,7 +121,7 @@ for alg in algs
adaptive = true, dt = 0.1f0, save_everystep = false, callback = cb,
merge_callbacks = true)

@test norm(bench_sol.u - sol.u[1].u) < 2e-3
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 2e-3

@info "saveat and callbacks"

Expand All @@ -136,7 +136,7 @@ for alg in algs
tstops = [24.0f0, 40.0f0], saveat = [0.0f0, 9.1f0], reltol = 1.0f-6,
abstol = 1.0f-6)

@test norm(bench_sol.u - sol.u[1].u) < 6e-4
@test norm(bench_sol.u[end] - sol.u[1].u[end]) < 6e-4

@info "Unadaptive and Adaptive comparison"

Expand Down
Loading