Fix spelling error in determine_event_occurrence function #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d06f9bc.
ChrisRackauckas
force-pushed
the
fix-determine-event-occurrence-spelling
branch
from
bd5724c to
e811c7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a compilation error caused by incorrect function name
determine_event_occurrencewhich should bedetermine_event_occurance(missing 'r').Problem
The package failed to load due to
UndefVarError: determine_event_occurrence not defined in DiffEqBase. This is because the actual function name in DiffEqBase has a spelling error:determine_event_occurance(missing 'r' in "occurrence").Changes Made
DiffEqBase.determine_event_occurrence→DiffEqBase.determine_event_occurance@inline function DiffEqBase.determine_event_occurrence→@inline function DiffEqBase.determine_event_occuranceFiles Modified
src/ensemblegpukernel/integrators/integrator_utils.jl: Fixed both the function call and definitionTest Plan
using DiffEqGPUworks successfullyNotes
The spelling error in the function name is preserved in DiffEqBase for backward compatibility with internal APIs. This fix ensures DiffEqGPU.jl remains compatible with the current DiffEqBase implementation.
🤖 Generated with Claude Code