Skip to content

Don't default to MKL on EPYC #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 30, 2024
Merged

Don't default to MKL on EPYC #518

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
fe33807
Don't default to MKL on EPYC
ChrisRackauckas Jul 28, 2024
13c7996
import correctly
ChrisRackauckas Jul 28, 2024
c2e4532
Update Project.toml
ChrisRackauckas Jul 28, 2024
7175a9a
Update Project.toml
ChrisRackauckas Jul 29, 2024
0877d2c
Update qa.jl
ChrisRackauckas Jul 29, 2024
8210447
Update static_arrays.jl
ChrisRackauckas Jul 29, 2024
a8a6dbc
Update test/static_arrays.jl
ChrisRackauckas Jul 29, 2024
0ca72d7
Update test/static_arrays.jl
ChrisRackauckas Jul 29, 2024
fe5e57f
Update adjoint.jl
ChrisRackauckas Jul 29, 2024
3634255
Update test/adjoint.jl
ChrisRackauckas Jul 29, 2024
4cdf9fc
Update static_arrays.jl
ChrisRackauckas Jul 29, 2024
26574e6
Update static_arrays.jl
ChrisRackauckas Jul 29, 2024
db50dd4
Update test/static_arrays.jl
ChrisRackauckas Jul 29, 2024
14f838f
Update static_arrays.jl
ChrisRackauckas Jul 30, 2024
96b7ead
Update test/static_arrays.jl
ChrisRackauckas Jul 30, 2024
067c31b
Update test/static_arrays.jl
ChrisRackauckas Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/static_arrays.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ for alg in (nothing, LUFactorization(), SVDFactorization(), CholeskyFactorizatio
sol = solve(LinearProblem(A, b), alg)
@inferred solve(LinearProblem(A, b), alg)
@test norm(A * sol .- b) < 1e-10
if alg <: KrylovJL_GMRES
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if alg <: KrylovJL_GMRES
if alg isa KrylovJL_GMRES

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I had first 26574e6

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a isa T is like typeof(a) <: T, but the former is preferred.
If a isn't a type, a <: T doesn't make sense and will throw an error.
https://github.com/SciML/LinearSolve.jl/actions/runs/10153821474/job/28077889265?pr=518#step:6:1114

if typeof(alg) <: KrylovJL_GMRES
@test_broken __solve_no_alloc(A, b, alg) isa SciMLBase.LinearSolution
else
@test_nowarn __solve_no_alloc(A, b, alg) isa SciMLBase.LinearSolution
Expand Down
Loading