Skip to content

Conversation

oscardssmith
Copy link
Member

we had this args field that was never being used, but did break remake.

# before:
julia> remake(KrylovJL_GMRES(), precs=nothing).kwargs
pairs(::NamedTuple) with 1 entry:
  :args => ()
# after:
julia> remake(KrylovJL_GMRES(), precs=nothing).kwargs
Base.Pairs{Symbol, Union{}, Tuple{}, @NamedTuple{}}()

As a side-note, we should fix the default SciMLBase remake for structs with fields named both args and kwargs

@oscardssmith
Copy link
Member Author

I think the proper fix here is actually SciML/SciMLBase.jl#769 (although it does appear that this functionality may not quite be working as intended)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant