Skip to content

Make SparseArrays a weakdeps and add it as dependency of Sparspak and Pardiso extensions #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 28, 2025
Merged

Make SparseArrays a weakdeps and add it as dependency of Sparspak and Pardiso extensions #584

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
572001e
Add SparseArrays to weakdeps
devmotion Feb 25, 2025
b35e48f
Fix dependency of Sparspak
devmotion Feb 25, 2025
2408d9f
Revert stdlib changes
devmotion Feb 25, 2025
e9ee570
Update RecursiveArrayTools compat
devmotion Feb 25, 2025
2902619
Update Pardiso extension
devmotion Feb 25, 2025
8b64988
Remove regular dependency
devmotion Feb 27, 2025
59d59a2
Revert changes of downgrade action
devmotion Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/Downgrade.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
version: ['1']
version: ['min']
group:
- Core
- Enzyme
Expand Down
8 changes: 4 additions & 4 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
SciMLOperators = "c0aeaf25-5076-4817-a8d5-81caf7dfa961"
Setfield = "efcf1570-3423-57d1-acb7-fd33fddbac46"
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
StaticArraysCore = "1e83bf80-4336-4d27-bf5d-d5a4f845583c"
UnPack = "3a884ed6-31ef-47d7-9d2a-63182c4928ed"

Expand All @@ -43,6 +42,7 @@ KrylovKit = "0b1a1467-8014-51b9-945f-bf0ae24f4b77"
Metal = "dde4c033-4e86-420c-a63e-0dd931031962"
Pardiso = "46dd5b70-b6fb-5a00-ae2d-e8fea33afaf2"
RecursiveFactorization = "f2c3362d-daeb-58d1-803e-2bc74f2840b4"
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
Sparspak = "e56a9233-b9d6-4f03-8d0f-1825330902ac"

[extensions]
Expand All @@ -58,10 +58,10 @@ LinearSolveIterativeSolversExt = "IterativeSolvers"
LinearSolveKernelAbstractionsExt = "KernelAbstractions"
LinearSolveKrylovKitExt = "KrylovKit"
LinearSolveMetalExt = "Metal"
LinearSolvePardisoExt = "Pardiso"
LinearSolvePardisoExt = ["Pardiso", "SparseArrays"]
LinearSolveRecursiveFactorizationExt = "RecursiveFactorization"
LinearSolveSparseArraysExt = "SparseArrays"
LinearSolveSparspakExt = "Sparspak"
LinearSolveSparspakExt = ["SparseArrays", "Sparspak"]

[compat]
AllocCheck = "0.2"
Expand Down Expand Up @@ -102,7 +102,7 @@ Pkg = "1"
PrecompileTools = "1.2"
Preferences = "1.4"
Random = "1"
RecursiveArrayTools = "3.8"
RecursiveArrayTools = "3.27.2"
RecursiveFactorization = "0.2.14"
Reexport = "1"
SafeTestsets = "0.1"
Expand Down
5 changes: 3 additions & 2 deletions ext/LinearSolvePardisoExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
module LinearSolvePardisoExt

using Pardiso, LinearSolve, SciMLBase
using Pardiso, LinearSolve
using SparseArrays
using SparseArrays: nonzeros, rowvals, getcolptr
using LinearSolve: PardisoJL

using UnPack
using LinearSolve.SciMLBase
using LinearSolve.UnPack

LinearSolve.needs_concrete_A(alg::PardisoJL) = true

Expand Down
Loading