Skip to content

Removed deprecated functionality #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 22, 2025
Merged

Removed deprecated functionality #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7bddf5
Removed deprecated functionality
ChrisRackauckas Mar 22, 2025
760fec0
Update LinearSolve.jl
ChrisRackauckas Mar 22, 2025
779976a
Update pardiso.jl
ChrisRackauckas Mar 22, 2025
0504851
Setup backwards compat
ChrisRackauckas Mar 22, 2025
40849d6
Update src/LinearSolve.jl
ChrisRackauckas Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/LinearSolve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,15 @@ include("solve_function.jl")
include("default.jl")
include("init.jl")
include("adjoint.jl")
include("deprecated.jl")

## Deprecated, remove in July 2025

@static if isdefined(SciMLBase, :DiffEqArrayOperator)
function defaultalg(A::SciMLBase.DiffEqArrayOperator, b,
assump::OperatorAssumptions{Bool})
defaultalg(A.A, b, assump)
end
end

@inline function _notsuccessful(F::LinearAlgebra.QRCompactWY)
(m, n) = size(F)
Expand Down
2 changes: 1 addition & 1 deletion src/default.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ end
# For SciML algorithms already using `defaultalg`, all assume square matrix.
defaultalg(A, b) = defaultalg(A, b, OperatorAssumptions(true))

function defaultalg(A::Union{DiffEqArrayOperator, MatrixOperator}, b,
function defaultalg(A::MatrixOperator, b,
assump::OperatorAssumptions{Bool})
defaultalg(A.A, b, assump)
end
Expand Down
85 changes: 0 additions & 85 deletions src/deprecated.jl
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions test/pardiso/pardiso.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,17 @@ prob = LinearProblem(copy(A), copy(b1))

linsolve = init(prob, UMFPACKFactorization())
sol11 = solve!(linsolve)
linsolve = LinearSolve.set_b(sol11.cache, copy(b2))
linsolve.b = copy(b2)
sol12 = solve!(linsolve)
linsolve = LinearSolve.set_A(sol12.cache, copy(A2))
linsolve.A = copy(A2)
sol13 = solve!(linsolve)

for alg in algs
linsolve = init(prob, alg)
sol31 = solve!(linsolve)
linsolve = LinearSolve.set_b(sol31.cache, copy(b2))
linsolve.b = copy(b2)
sol32 = solve!(linsolve)
linsolve = LinearSolve.set_A(sol32.cache, copy(A2))
linsolve.A = copy(A2)
sol33 = solve!(linsolve)
@test sol11.u ≈ sol31.u
@test sol12.u ≈ sol32.u
Expand Down
Loading