Fix successful return codes for factorization methods #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -258,5 +263,5 @@ function SciMLBase.solve!(cache::LinearCache, alg::AppleAccelerateLUFactorizatio | |||
| aa_getrs!('N', A.factors, A.ipiv, cache.u; info) | |||
| end | |||
|
|
|||
| SciMLBase.build_linear_solution(alg, cache.u, nothing, cache) | |||
| SciMLBase.build_linear_solution(alg, cache.u, nothing, cache; retcode = ReturnCode.Success) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| SciMLBase.build_linear_solution(alg, cache.u, nothing, cache; retcode = ReturnCode.Success) | |
| SciMLBase.build_linear_solution( | |
| alg, cache.u, nothing, cache; retcode = ReturnCode.Success) |
| @@ -953,6 +953,12 @@ A fast factorization which uses a Cholesky factorization on A * A'. Can be much | |||
| faster than LU factorization, but is not as numerically stable and thus should only | |||
| be applied to well-conditioned matrices. | |||
|
|
|||
| !!! warn | |||
| `NormalCholeskyFactorization` should only be applied to well-conditioned matrices. As a | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| `NormalCholeskyFactorization` should only be applied to well-conditioned matrices. As a | |
| `NormalCholeskyFactorization` should only be applied to well-conditioned matrices. As a |
| @@ -1010,6 +1016,12 @@ | |||
| fact = cholesky(Symmetric((A)' * A), alg.pivot; check = false) | |||
| end | |||
| cache.cacheval = fact | |||
|
|
|||
| if hasmethod(LinearAlgebra.issuccess, Tuple{typeof(fact)}) && !LinearAlgebra.issuccess(fact) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| if hasmethod(LinearAlgebra.issuccess, Tuple{typeof(fact)}) && !LinearAlgebra.issuccess(fact) | |
| if hasmethod(LinearAlgebra.issuccess, Tuple{typeof(fact)}) && | |
| !LinearAlgebra.issuccess(fact) |
ChrisRackauckas
commented
Jul 14, 2025
Comment on lines
+43
to
+44
| # This is a known and documented incorrectness in NormalCholeskyFactorization | ||
| # due to numerical instability in its method that is fundamental. |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # This is a known and documented incorrectness in NormalCholeskyFactorization | |
| # due to numerical instability in its method that is fundamental. | |
| # This is a known and documented incorrectness in NormalCholeskyFactorization | |
| # due to numerical instability in its method that is fundamental. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #630 fixes #532