Use explicit imports #635
Merged
Use explicit imports #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ``` | ||
|
|
||
| Note that CUSPARSE also has some GPU-based preconditioners, such as a built-in `ilu`. However: | ||
|
|
||
| ```julia | ||
| sol = solve(prob, KrylovJL_GMRES(precs = (A, p) -> (CUDA.CUSPARSE.ilu02!(A, 'O'), I))) | ||
| sol = LS.solve(prob, LS.KrylovJL_GMRES(precs = (A, p) -> (CUDA.CUSPARSE.ilu02!(A, 'O'), LA.I))) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| sol = LS.solve(prob, LS.KrylovJL_GMRES(precs = (A, p) -> (CUDA.CUSPARSE.ilu02!(A, 'O'), LA.I))) | |
| sol = LS.solve( | |
| prob, LS.KrylovJL_GMRES(precs = (A, p) -> (CUDA.CUSPARSE.ilu02!(A, 'O'), LA.I))) |
Comment on lines
+162
to
164
| Note that not all methods can use a matrix-free operator. For example, `LS.LUFactorization()` requires a matrix. If you use an | ||
| invalid method, you will get an error. The methods particularly from KrylovJL are the ones preferred for these cases | ||
| (and are defaulted to). |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| Note that not all methods can use a matrix-free operator. For example, `LS.LUFactorization()` requires a matrix. If you use an | |
| invalid method, you will get an error. The methods particularly from KrylovJL are the ones preferred for these cases | |
| (and are defaulted to). | |
| Note that not all methods can use a matrix-free operator. For example, `LS.LUFactorization()` requires a matrix. If you use an | |
| invalid method, you will get an error. The methods particularly from KrylovJL are the ones preferred for these cases | |
| (and are defaulted to). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.