Skip to content

Fix LinearSolveCUDAExt.jl #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 22, 2025
Merged

Fix LinearSolveCUDAExt.jl #639

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cb435d8
Fix LinearSolveCUDAExt.jl
ChrisRackauckas Jul 22, 2025
fa1956b
Update LinearSolveCUDAExt.jl
ChrisRackauckas Jul 22, 2025
1dc65c5
Update LinearSolveCUDAExt.jl
ChrisRackauckas Jul 22, 2025
51bd688
Update LinearSolveCUDAExt.jl
ChrisRackauckas Jul 22, 2025
e972624
Update LinearSolveCUDAExt.jl
ChrisRackauckas Jul 22, 2025
ace17c7
Update LinearSolveCUDAExt.jl
ChrisRackauckas Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/LinearSolveCUDAExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module LinearSolveCUDAExt
using CUDA
using LinearSolve: LinearSolve, is_cusparse, defaultalg, cudss_loaded, DefaultLinearSolver,
DefaultAlgorithmChoice, ALREADY_WARNED_CUDSS, LinearCache, needs_concrete_A,
error_no_cudss_lu, CUDSS_LOADED, init_cacheval
error_no_cudss_lu, init_cacheval
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still used throughout this file

using LinearSolve.LinearAlgebra, LinearSolve.SciMLBase, LinearSolve.ArrayInterface
using SciMLBase: AbstractSciMLOperator

Expand All @@ -25,7 +25,7 @@ function LinearSolve.defaultalg(A::CUDA.CUSPARSE.CuSparseMatrixCSR{Tv, Ti}, b,
end

function LinearSolve.error_no_cudss_lu(A::CUDA.CUSPARSE.CuSparseMatrixCSR)
if !LinearSolve.CUDSS_LOADED[]
if !LinearSolve.cudss_loaded[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this a function?

error("CUDSS.jl is required for LU Factorizations on CuSparseMatrixCSR. Please load this library.")
end
nothing
Expand Down
Loading