Fix Julia deprecation warnings in CI scripts and tests #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace julia-actions/julia-buildpkg@latest with @v1.7.0 in Downstream.yml - Update julia-actions/julia-buildpkg from @v1 to @v1.7.0 (latest) in Downgrade.yml - Update julia-actions/julia-runtest from @v1 to @v1.11.2 (latest) in Downgrade.yml These changes address deprecated @latest tag usage and update actions to their most recent stable versions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Standardize LAPACK.chkfinite call to use LinearAlgebra.LAPACK.chkfinite for consistency - Fixes potential Julia deprecation warning from inconsistent module usage 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Replace deprecated keyword arguments alias_A and alias_b with LinearAliasSpecifier - Resolves Julia deprecation warnings when running tests with --depwarn=error - Updates test/resolve.jl:78 to use modern API 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -75,7 +75,7 @@ A = [1.0 2.0 | |||
| A = Symmetric(A * A') | |||
| b = [1.0, 2.0] | |||
| prob = LinearProblem(A, b) | |||
| linsolve = init(prob, CholeskyFactorization(), alias_A = false, alias_b = false) | |||
| linsolve = init(prob, CholeskyFactorization(), alias = LinearAliasSpecifier(alias_A = false, alias_b = false)) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| linsolve = init(prob, CholeskyFactorization(), alias = LinearAliasSpecifier(alias_A = false, alias_b = false)) | |
| linsolve = init( | |
| prob, CholeskyFactorization(), alias = LinearAliasSpecifier( | |
| alias_A = false, alias_b = false)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@latesttag usage in GitHub Actions workflowsChanges Made
GitHub Actions Updates
julia-actions/julia-buildpkg@latestwith@v1.7.0in Downstream.ymljulia-actions/julia-buildpkgfrom@v1to@v1.7.0(latest) in Downgrade.ymljulia-actions/julia-runtestfrom@v1to@v1.11.2(latest) in Downgrade.ymlJulia Language Fixes
src/generic_lufact.jl:72LAPACK.chkfinite(A)toLinearAlgebra.LAPACK.chkfinite(A)for consistency with line 8alias_Aandalias_busage intest/resolve.jl:78LinearAliasSpecifierAPI to eliminate deprecation warningsTest Plan
--depwarn=yesflag--depwarn=errorafter fixing deprecated API usageVerification
The deprecation warning fix was tested with:
🤖 Generated with Claude Code