Fix unnecessary line splits following Catalyst.jl PR #1306 #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unnecessarily split test assertions in default_algs.jl and basictests.jl following Catalyst.jl PR #1306 guidelines for improved readability. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+510
to
+511
| @test LinearSolve.defaultalg(op1, x1).alg === LinearSolve.DefaultAlgorithmChoice.DirectLdiv! | ||
| @test LinearSolve.defaultalg(op2, x2).alg === LinearSolve.DefaultAlgorithmChoice.DirectLdiv! |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test LinearSolve.defaultalg(op1, x1).alg === LinearSolve.DefaultAlgorithmChoice.DirectLdiv! | |
| @test LinearSolve.defaultalg(op2, x2).alg === LinearSolve.DefaultAlgorithmChoice.DirectLdiv! | |
| @test LinearSolve.defaultalg(op1, x1).alg === | |
| LinearSolve.DefaultAlgorithmChoice.DirectLdiv! | |
| @test LinearSolve.defaultalg(op2, x2).alg === | |
| LinearSolve.DefaultAlgorithmChoice.DirectLdiv! |
| @@ -1,7 +1,6 @@ | |||
| using LinearSolve, RecursiveFactorization, LinearAlgebra, SparseArrays, Test | |||
|
|
|||
| @test LinearSolve.defaultalg(nothing, zeros(3)).alg === | |||
| LinearSolve.DefaultAlgorithmChoice.GenericLUFactorization | |||
| @test LinearSolve.defaultalg(nothing, zeros(3)).alg === LinearSolve.DefaultAlgorithmChoice.GenericLUFactorization | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test LinearSolve.defaultalg(nothing, zeros(3)).alg === LinearSolve.DefaultAlgorithmChoice.GenericLUFactorization | |
| @test LinearSolve.defaultalg(nothing, zeros(3)).alg === | |
| LinearSolve.DefaultAlgorithmChoice.GenericLUFactorization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix unnecessary line splits in Julia code following the guidelines established in Catalyst.jl PR #1306. This PR improves code readability by consolidating short expressions that were unnecessarily split across multiple lines.
Background
These formatting issues are being addressed upstream in JuliaFormatter.jl PR #934, which implements algorithmic fixes to prevent these unnecessary line splits. However, since that PR is not yet merged, manual fixes are needed in the meantime to improve code readability.
Changes Made
Fixed 5 instances of problematic line splits in test files:
Example Fix
Before:
After:
Rationale
Following Catalyst.jl PR #1306's approach:
Note
This is part of a systematic effort to apply the same formatting improvements across multiple SciML repositories including JumpProcesses.jl, OrdinaryDiffEq.jl, NonlinearSolve.jl, and ModelingToolkit.jl.
🤖 Generated with Claude Code