Skip to content

Fix unnecessary line splits following Catalyst.jl PR #1306 #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025
Merged

Fix unnecessary line splits following Catalyst.jl PR #1306 #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions test/basictests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,10 +507,8 @@ end
prob3 = LinearProblem(op1, b1; u0 = x1)
prob4 = LinearProblem(op2, b2; u0 = x2)

@test LinearSolve.defaultalg(op1, x1).alg ===
LinearSolve.DefaultAlgorithmChoice.DirectLdiv!
@test LinearSolve.defaultalg(op2, x2).alg ===
LinearSolve.DefaultAlgorithmChoice.DirectLdiv!
@test LinearSolve.defaultalg(op1, x1).alg === LinearSolve.DefaultAlgorithmChoice.DirectLdiv!
@test LinearSolve.defaultalg(op2, x2).alg === LinearSolve.DefaultAlgorithmChoice.DirectLdiv!
Comment on lines +510 to +511
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
@test LinearSolve.defaultalg(op1, x1).alg === LinearSolve.DefaultAlgorithmChoice.DirectLdiv!
@test LinearSolve.defaultalg(op2, x2).alg === LinearSolve.DefaultAlgorithmChoice.DirectLdiv!
@test LinearSolve.defaultalg(op1, x1).alg ===
LinearSolve.DefaultAlgorithmChoice.DirectLdiv!
@test LinearSolve.defaultalg(op2, x2).alg ===
LinearSolve.DefaultAlgorithmChoice.DirectLdiv!

@test LinearSolve.defaultalg(op3, x1).alg ===
LinearSolve.DefaultAlgorithmChoice.KrylovJL_GMRES
@test LinearSolve.defaultalg(op4, x2).alg ===
Expand Down
3 changes: 1 addition & 2 deletions test/default_algs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
using LinearSolve, RecursiveFactorization, LinearAlgebra, SparseArrays, Test

@test LinearSolve.defaultalg(nothing, zeros(3)).alg ===
LinearSolve.DefaultAlgorithmChoice.GenericLUFactorization
@test LinearSolve.defaultalg(nothing, zeros(3)).alg === LinearSolve.DefaultAlgorithmChoice.GenericLUFactorization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
@test LinearSolve.defaultalg(nothing, zeros(3)).alg === LinearSolve.DefaultAlgorithmChoice.GenericLUFactorization
@test LinearSolve.defaultalg(nothing, zeros(3)).alg ===
LinearSolve.DefaultAlgorithmChoice.GenericLUFactorization

prob = LinearProblem(rand(3, 3), rand(3))
solve(prob)

Expand Down
Loading