Skip to content

Fix slow triangular matrix solves by using DirectLdiv\! #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2025
Merged

Fix slow triangular matrix solves by using DirectLdiv\! #672

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb1ec76
Fix slow triangular matrix solves by using DirectLdiv\! directly
ChrisRackauckas Aug 4, 2025
ba297ba
Update src/default.jl
ChrisRackauckas Aug 4, 2025
f7cefbc
Update src/default.jl
ChrisRackauckas Aug 4, 2025
fb19793
Update src/default.jl
ChrisRackauckas Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/default.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,17 +71,29 @@ end

function defaultalg(A::Tridiagonal, b, assump::OperatorAssumptions{Bool})
if assump.issq
DefaultLinearSolver(DefaultAlgorithmChoice.LUFactorization)
@static if VERSION>=v"1.11"
DirectLdiv!()
else
DefaultLinearSolver(DefaultAlgorithmChoice.LUFactorization)
end
else
DefaultLinearSolver(DefaultAlgorithmChoice.QRFactorization)
end
end

function defaultalg(A::SymTridiagonal, b, ::OperatorAssumptions{Bool})
DefaultLinearSolver(DefaultAlgorithmChoice.LDLtFactorization)
@static if VERSION>=v"1.11"
DirectLdiv!()
else
DefaultLinearSolver(DefaultAlgorithmChoice.LUFactorization)
end
end
function defaultalg(A::Bidiagonal, b, ::OperatorAssumptions{Bool})
DefaultLinearSolver(DefaultAlgorithmChoice.DirectLdiv!)
@static if VERSION>=v"1.11"
DirectLdiv!()
else
DefaultLinearSolver(DefaultAlgorithmChoice.LUFactorization)
end
end
function defaultalg(A::Factorization, b, ::OperatorAssumptions{Bool})
DefaultLinearSolver(DefaultAlgorithmChoice.DirectLdiv!)
Expand Down
Loading