Improve error messages in LinearSolveAutotune telemetry #703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves error messages when LinearSolveAutotune fails to upload benchmark results to GitHub, making it easier to diagnose and fix authentication/permission issues.
Motivation
As seen in issue #669, when the autotune system fails to upload results, the error messages don't provide enough information to understand why it failed. This makes it difficult for users to fix the issue.
Changes
Enhanced Error Reporting
@warn
to@error
for critical failuresSpecific Error Guidance
Added pattern matching for common HTTP errors with actionable advice:
gh auth login
Improved Error Propagation
comment_on_issue_api
andcomment_on_issue_gh
to properly propagate errorsUser-Friendly Fallback
When upload fails and results are saved locally:
Example Output
Before:
After:
Test Plan
This improvement will help users understand and resolve upload failures more effectively.
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]