Add MKL preference management to autotune system #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Analyze if MKL algorithms (MKLLUFactorization) perform best in any category - Write LoadMKL_JLL preference based on benchmark results - Set to false if MKL is never best to avoid loading unnecessary dependencies - Set to true if MKL wins in any category to ensure availability - Add MKL preference display in show_current_preferences - Include MKL preference clearing in clear_algorithm_preferences This optimization reduces startup time and memory usage when MKL is not beneficial for the user's workload.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -23,13 +23,21 @@ function set_algorithm_preferences(categories::Dict{String, String}) | |||
|
|
|||
| # Extract benchmarked results by element type and size | |||
| benchmarked = Dict{String, Dict{String, String}}() | |||
| mkl_is_best_somewhere = false # Track if MKL wins any category | |||
|
|
|||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| for (key, algorithm) in categories | ||
| if contains(key, "_") | ||
| eltype, size_range = split(key, "_", limit=2) | ||
| if !haskey(benchmarked, eltype) | ||
| benchmarked[eltype] = Dict{String, String}() | ||
| end | ||
| benchmarked[eltype][size_range] = algorithm | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
- Set LoadMKL_JLL=true before loading LinearSolve in autotune module - This ensures MKL algorithms are available for benchmarking - Track the original preference to inform user of temporary change - Final preference is still set based on benchmark results - Added documentation explaining this behavior
| # Note: During benchmarking, MKL is temporarily enabled to test MKL algorithms | ||
| # This final preference setting determines whether MKL loads in normal usage | ||
| Preferences.set_preferences!(LinearSolve, "LoadMKL_JLL" => mkl_is_best_somewhere; force = true) | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| else | ||
| @info "MKL was not best in any category - setting LoadMKL_JLL preference to false to avoid loading unnecessary dependencies" | ||
| end | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # Clear MKL preference | ||
| Preferences.delete_preferences!(LinearSolve, "LoadMKL_JLL"; force = true) | ||
| @info "Cleared MKL preference" | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| if mkl_pref !== nothing | ||
| println("\nMKL Usage: $(mkl_pref ? "Enabled" : "Disabled")") | ||
| end | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
This PR adds MKL preference management to the autotune system:
Benefits
Testing
Added test file to verify: