Add detailed CPU information from Sys.cpu_info() to telemetry #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract CPU model and speed from Sys.cpu_info() - Display CPU model instead of generic CPU_NAME where available - Show CPU speed in MHz for better hardware identification - Detect heterogeneous CPU configurations - Calculate average/min/max speeds for systems with varying CPU speeds - Update telemetry output to show CPU model in GitHub issue comments - Maintain backward compatibility with existing cpu_name field This provides more specific hardware information for better benchmark analysis.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| first_cpu = cpu_info[1] | ||
| info["cpu_model"] = first_cpu.model | ||
| info["cpu_speed_mhz"] = first_cpu.speed | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| info["cpu_model"] = "Unknown" | ||
| info["cpu_speed_mhz"] = 0 | ||
| end | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| first_cpu = cpu_info[1] | ||
| system_data["cpu_model"] = first_cpu.model | ||
| system_data["cpu_speed_mhz"] = first_cpu.speed | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| else | ||
| system_data["heterogeneous_cpus"] = false | ||
| end | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # Calculate average CPU speed if speeds vary | ||
| cpu_speeds = [cpu.speed for cpu in cpu_info] | ||
| if length(unique(cpu_speeds)) > 1 | ||
| system_data["cpu_speed_avg_mhz"] = round(mean(cpu_speeds), digits=0) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| system_data["cpu_speed_avg_mhz"] = round(mean(cpu_speeds), digits=0) | |
| system_data["cpu_speed_avg_mhz"] = round(mean(cpu_speeds), digits = 0) |
| system_data["cpu_model"] = "unknown" | ||
| system_data["cpu_speed_mhz"] = 0 | ||
| end | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Comment on lines
208
to
+209
| push!(lines, "- **Architecture**: $(get(system_info, "architecture", get(system_info, "arch", "unknown")))") | ||
| push!(lines, "- **CPU**: $(get(system_info, "cpu_name", "unknown"))") | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| push!(lines, "- **Architecture**: $(get(system_info, "architecture", get(system_info, "arch", "unknown")))") | |
| push!(lines, "- **CPU**: $(get(system_info, "cpu_name", "unknown"))") | |
| push!(lines, | |
| "- **Architecture**: $(get(system_info, "architecture", get(system_info, "arch", "unknown")))") | |
| # Fallback to legacy CPU name | ||
| push!(lines, "- **CPU**: $(get(system_info, "cpu_name", "unknown"))") | ||
| end | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
This PR enhances the system information collection in LinearSolveAutotune by extracting detailed CPU information from Julia's function:
New Information Collected:
Display Updates:
Backward Compatibility:
Example Output
Before:
After:
Testing
Added test file that verifies:
Benefits