Skip to content

Update jet.jl tests #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 10, 2025
Merged

Update jet.jl tests #710

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bacb4c3
Update jet.jl tests
ChrisRackauckas Aug 10, 2025
1013840
Apply suggestions from code review
ChrisRackauckas Aug 10, 2025
6098c21
Update test/nopre/jet.jl
ChrisRackauckas Aug 10, 2025
d785a88
Update jet.jl
ChrisRackauckas Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/nopre/jet.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ prob_sparse_spd = LinearProblem(A_sparse_spd, b)
JET.@test_opt solve(prob, GenericLUFactorization())
JET.@test_opt solve(prob, DiagonalFactorization())
JET.@test_opt solve(prob, SimpleLUFactorization())
JET.@test_opt solve(prob_spd, NormalCholeskyFactorization()) broken=true
JET.@test_opt solve(prob, NormalBunchKaufmanFactorization())
# JET.@test_opt solve(prob_spd, NormalCholeskyFactorization())
# JET.@test_opt solve(prob, NormalBunchKaufmanFactorization())

# CholeskyFactorization and SVDFactorization now pass JET tests
JET.@test_opt solve(prob_spd, CholeskyFactorization()) broken=true
JET.@test_opt solve(prob, SVDFactorization()) broken=true
# JET.@test_opt solve(prob_spd, CholeskyFactorization())
# JET.@test_opt solve(prob, SVDFactorization())

# Tests with known type stability issues - marked as broken
JET.@test_opt solve(prob, QRFactorization()) broken=true
Expand All @@ -45,7 +45,7 @@ end

@testset "JET Tests for Extension Factorizations" begin
# RecursiveFactorization.jl extensions
JET.@test_opt solve(prob, RFLUFactorization())
# JET.@test_opt solve(prob, RFLUFactorization())

# Tests with known type stability issues
JET.@test_opt solve(prob, FastLUFactorization()) broken=true
Expand Down Expand Up @@ -107,4 +107,4 @@ end
# Test the default solver selection
JET.@test_opt solve(prob) broken=true
JET.@test_opt solve(prob_sparse) broken=true
end
end
Loading