Fix hanging issue in autotune timeout mechanism #717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The autotune feature would hang indefinitely when trying to timeout slow algorithms. This was caused by the timeout implementation attempting to forcefully interrupt tasks using
Base.throwto()
, which doesn't reliably work with tasks that are in certain states (like sleeping or blocked I/O).Solution
Replace the problematic timeout mechanism with a more robust approach:
timedwait()
function instead of manual pollingBase.throwto()
which can cause hangsChanges
benchmark_algorithms()
inbenchmarking.jl
to usetimedwait()
Testing
Tested the new implementation with various timeout scenarios:
The autotune now properly handles timeouts without hanging, recording timed-out tests as NaN and continuing with the next algorithm.
Fixes the hanging issue reported after merging #716.