-
-
Notifications
You must be signed in to change notification settings - Fork 69
Pure-Julia Sparse Cholesky #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ext/LinearSolveCliqueTreesExt.jl
Outdated
A = [ | ||
3 1 0 0 0 0 0 0 | ||
1 3 1 0 0 2 0 0 | ||
0 1 3 1 0 1 2 1 | ||
0 0 1 3 0 0 0 0 | ||
0 0 0 0 3 1 1 0 | ||
0 2 1 0 1 3 0 0 | ||
0 0 2 0 1 0 3 1 | ||
0 0 1 0 0 0 1 3 | ||
]; | ||
|
||
b = rand(8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not supposed to be a sparse matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sparse, now. Converted internally in any case: I was trying to avoid using SparseArrays
from some reason.
ext/LinearSolveCliqueTreesExt.jl
Outdated
|
||
b = rand(8) | ||
prob = LinearProblem(A, b) | ||
sol = solve(prob) # in case cliquetrees is used as default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sol = solve(prob) # in case cliquetrees is used as default |
It's not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had copied that from the Sparsepak extension. Gone, now.
This PR adds the Cholesky factorization algorithm implemented in CliqueTrees.jl. It is written in pure-Julia and accepts arbitrary numeric types. Somewhat slower than CHOLMOD. See this discourse thread.
Example
output:
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.