Remove deepcopy
in solve!
for DualLinearCache, put Dual types in type system
#724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Trying to address SciML/OrdinaryDiffEq.jl#2837 and #648
This gets rid of the call to
deepcopy
.This also puts the type of the dual number that needs to be constructed in to the type system instead of having it be a field in the dual caches. I'm not sure if that will help with trimming but I think in general it's a better way to do this.