Display NaN values in LinearSolveAutotune telemetry output #729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the LinearSolveAutotune telemetry system filtered out NaN values from failed benchmark results, making it unclear what algorithms were actually tested but unsuccessful. This PR improves transparency by displaying all attempted algorithms, including those that failed.
Changes
🔧 Telemetry Display Improvements
📊 Before vs After
Before: Only successful results were shown, hiding what was actually attempted
After: All attempts are visible with clear success/failure indication
Files Modified
lib/LinearSolveAutotune/src/telemetry.jl
: Updatedformat_results_for_github()
andformat_detailed_results_markdown()
to include failed resultslib/LinearSolveAutotune/src/LinearSolveAutotune.jl
: Enhanced console output and summary tables to show all tested algorithmsTest Results
Verified that:
Benefits
This addresses user feedback requesting visibility into failed benchmark attempts that were previously hidden from telemetry output.
🤖 Generated with Claude Code