Fix Pardiso memory leak by adding finalizer #734
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pardiso allocates internal memory during ANALYSIS and NUM_FACT phases but never releases it, causing memory leaks in long-running simulations with many linear solve calls. This commit adds a finalizer to the Pardiso solver object that: - Sets the phase to RELEASE_ALL (-1) when the solver is garbage collected - Calls pardiso with empty matrices to trigger the memory cleanup - Follows the same pattern as KLU which uses finalizers for cleanup The fix ensures that Pardiso's internal buffers are properly released when the LinearCache is garbage collected, preventing memory accumulation over time. Fixes SciML#593 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Closed
Contributor
|
Finalizers are now in Pardiso v1.1 . |
ChrisRackauckas-Claude
pushed a commit
to ChrisRackauckas-Claude/LinearSolve.jl
that referenced
this pull request
Nov 14, 2025
…rization This PR adds trimming tests to LinearSolve.jl, similar to PR SciML#734 in NonlinearSolve.jl. ## Summary - Add `test/trim/` directory with infrastructure for testing trimming - Add tests for LUFactorization, MKLLUFactorization, and RFLUFactorization - Add "Trim" test group to CI configuration - Tests only run on Julia 1.12+ (when trimming was introduced) ## Test Structure The tests verify: 1. LUFactorization works correctly with pre-initialized cache 2. MKLLUFactorization works correctly with pre-initialized cache 3. RFLUFactorization works correctly with pre-initialized cache 4. Each implementation can be successfully compiled with \`juliac --trim\` ## Notes - Trim tests only run on Julia 1.12+ - CI excludes trim tests on LTS and pre-release versions - Tests use a custom environment in \`test/trim/\` to avoid conflicts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Pardiso allocates internal memory during ANALYSIS and NUM_FACT phases but never releases it, causing memory leaks when the solver is used repeatedly in long-running simulations.
Solution
Added a finalizer to the Pardiso solver object that:
Test plan
The test creates multiple LinearProblems and solves them repeatedly, checking that:
🤖 Generated with Claude Code