Fix missing imports in CUDA extension #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing imports for LU, CuVector, CuMatrix, and LinearVerbosity to fix compilation errors in LinearSolveCUDAExt. Fixes the issue reported at: https://discourse.julialang.org/t/linearsolvecudaext-fails-to-compile/131693/2 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Add [sources] section with paths to LinearSolveAutotune and LinearSolve packages for proper local development setup. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ttern - Remove sources section from lib/LinearSolveAutotune/Project.toml - Add sources section to main LinearSolve.jl Project.toml - This follows the same pattern used in OrdinaryDiffEq.jl where sources are defined in the main package Project.toml, not in individual lib packages 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove incorrectly added sources from main Project.toml - Add sources section to LinearSolveAutotune/Project.toml pointing to LinearSolve - This allows LinearSolveAutotune to use the local LinearSolve package during development 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove stub init_cacheval for CudaOffloadLUFactorization from base package to avoid method overwriting error during precompilation - Move CUDA from deps to weakdeps since it's only needed for the extension These changes fix: 1. Method overwriting error during module precompilation 2. Aqua.jl stale deps test failure for CUDA 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
LU,CuVector,CuMatrix, andLinearVerbosityChanges
The CUDA extension was failing to compile due to missing imports. This PR adds the necessary imports:
using CUDA: CuVector, CuMatrix- Required for CUDA array types used ininit_cachevalusing LinearAlgebra: LU- Required for the LU factorization typeLinearVerbosityto the imports from LinearSolve - Required for function signaturesTest plan
🤖 Generated with Claude Code