Add availability checks for MKL and OpenBLAS similar to AppleAccelerate #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds runtime availability checks for MKL and OpenBLAS libraries to ensure proper error handling when the libraries are not available. The implementation follows the same pattern as AppleAccelerateLU: - Added __mkl_isavailable() function to check MKL library availability - Added __openblas_isavailable() function to check OpenBLAS library availability - Added error checks in all getrf!, getrs!, and solve! functions - Uses Libdl to check for library symbols at runtime This ensures that calls properly compile out when the binaries are missing and provides clear error messages when the libraries are not available. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Per review feedback, simplified the availability checks: - Removed try/catch blocks as they're unnecessary - Removed Libdl symbol checking - if the binary exists via is_available(), it's fine - Just check if the JLL module is defined and is_available() returns true This makes the code cleaner and follows the principle that if the binary exists, we can trust it has the required symbols. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Changed the availability check functions to use @static if for compile-time determination, matching the pattern used in AppleAccelerate: - Uses @static if to check @isdefined at compile time - Returns is_available() result statically when JLL is defined - Returns false statically when JLL is not defined This makes the checks more efficient as they're resolved at compile time rather than runtime. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR adds availability checks for MKL and OpenBLAS extensions following the same pattern used in AppleAccelerateLU:
Added availability check functions:
__mkl_isavailable()- Checks if MKL library is available and has required symbols__openblas_isavailable()- Checks if OpenBLAS library is available and has required symbolsAdded runtime checks in all solver functions:
getrf!functions now check library availability before callinggetrs!functions now check library availability before callingsolve!functions check availability at the startUsed Libdl for dynamic library checking:
Motivation
As mentioned in the request, this ensures that MKL and OpenBLAS calls properly compile out when the binaries are not available, similar to how AppleAccelerateLU already works. This prevents runtime errors and provides better error messages to users.
Test Plan
🤖 Generated with Claude Code