Replace unnecessary deepcopy calls with copy in tests #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per issue SciML#648, some deepcopy calls can be replaced with copy to improve binary trimming. This commit replaces deepcopy with copy in test files where the objects being copied are regular Julia arrays. - Replace deepcopy with copy for standard arrays in enzyme tests - Replace deepcopy with copy for sparse matrices in zeroinittests The main source files still use deepcopy for generic objects like FunctionOperator that don't have a copy method defined. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
deepcopydoesn't trim well #648 by replacingdeepcopycalls withcopywhere appropriateChanges
This PR replaces
deepcopywithcopyin test files where the objects being copied are regular Julia arrays or sparse matrices. The main source files still usedeepcopyfor generic objects likeFunctionOperatorthat don't have acopymethod defined.Modified files:
test/nopre/enzyme.jl: Replace deepcopy with copy for standard arraystest/zeroinittests.jl: Replace deepcopy with copy for sparse matricesTest plan
🤖 Generated with Claude Code